[Flightgear-devel] "A local file-system error occurred" error when installing aircraft via Qt launcher on Windows

[Denk Padje]

I have a user reporting that trying to install aircraft via the
launcher gives an error dialog with the message "An error occurred
installing the aircraft <name of aircraft> : A local file-system error
occurred". Sometimes the error doesn't occur and the user can install
several aircraft. But minutes later the error can pop up again.

Happens on 2016.4.4.

Here's the original message:

--------------------------------------------------------------------------------
This happens whenever I try to install any aircraft through the
launcher. It happens even when I run fg as admin.

Aircraft installation failed
----------------------------
An error occurred installing the aircraft Tupolev ANT 20 (YASim): A
local file-system error occurred

Relevant lines from log:
io:4:G:\Jenkins\workspace\Windows-release\simgear\simgear\misc\sg_path.cxx:787:rename
failed: from Path
"C:/Users/canki/Documents/FlightGear/Aircraft/org.flightgear.fgaddon/Aircraft/_extract_3b989b232dd121eff6b0b230e9e85f6c/Messerschmitt-P1101"
to Path "C:/Users/canki/Documents/FlightGear/Aircraft/org.flightgear.fgaddon/Aircraft/Messerschmitt-P1101"
reason: Permission denied
general:5:G:\Jenkins\workspace\Windows-release\simgear\simgear\package\Root.cxx:495:failed
to install package:p1101:6(edited)

For some reason, my entire Documents folder seems to be marked
read-only. Removing the attribute from documents/flightgear and
attempting again.
It does not let me change the read-only status of those folders. It
does, however, allow me to create and modify flies there.
When I attempt to remove the read-only flag from the folders, it seems
to do so, but the flag is still there when I check again.

It sometimes randomly permits me to install an aircraft.
The airplane does not seem to affect whether it works.
When it does not work, all airplanes cannot be installed.
It does download, but the error message appears when the download ends.
No airplane folder is left in the filesystem.

I am currently quickly installing several aircraft while it still works.

Here we go again...
(screenshot of error dialog)

Error log:

io:4:G:\Jenkins\workspace\Windows-release\simgear\simgear\misc\sg_path.cxx:787:rename
failed: from Path
"C:/Users/canki/Documents/FlightGear/Aircraft/org.flightgear.fgaddon/Aircraft/_extract_b71ea2a779253e68c4c923c587224b28/ATI-Resolution"
to Path "C:/Users/canki/Documents/FlightGear/Aircraft/org.flightgear.fgaddon/Aircraft/ATI-Resolution"
reason: Permission denied
general:5:G:\Jenkins\workspace\Windows-release\simgear\simgear\package\Root.cxx:495:failed
to install package:Resolution3:6
--------------------------------------------------------------------------------